Replace ancient lazy_static
crate with once_cell
or const
slices
#471
+93
−72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Piggybacking on the motivation in winit:
lazy_static!
is a macro whereasonce_cell
achieves the same using generics. Its implementation has also been proposed for inclusion instd
, making it easier to switch to a standardized version if/when that happens. The author of that winit PR is making this change to many more crates, slowly turning the scales in favour ofonce_cell
in most dependency trees. Furthermorelazy_static
hasn't published any updates for 3 years.See also the
once_cell
F.A.Q..In addition "constant"
Vec
tor allocations don't need to be wrapped in alazy_static!
macro call at all but can be replaced with trueconst
slices (orconst
sized arrays, but those are slightly more tedious to construct).